fix(NODE-7131): dont add duplicate metadata #4644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
reviewed
Sep 3, 2025
src/mongo_client.ts
Outdated
| */ | ||
| appendMetadata(driverInfo: DriverInfo) { | ||
| for (const info of this.options.additionalDriverInfo) { | ||
| if (info.name === driverInfo.name) { |
There was a problem hiding this comment.
I believe one of the things we need to consider in the related DRIVERS-3262 is whether we could be in a situation with the same name but a different version, and we're pretty sure we do want to preserve the info in that case
There was a problem hiding this comment.
I've updated to check version as well and added another test.
dariakp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents duplicate metadata for the same driver info name to be appended.
What is changing?
Checks the name of the driver info being appended. If it exists, it does not get added.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-7073
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript