Skip to content

fix(NODE-7131): dont add duplicate metadata #4644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(NODE-7131): dont add duplicate metadata #4644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
818d71e
fix(NODE-7073): dont add duplicate metadata
durran Aug 29, 2025
5206d9c
chore: comments
durran Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/mongo_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,11 @@ export class MongoClient extends TypedEventEmitter<MongoClientEvents> implements
* @param driverInfo - Information about the application or library.
*/
appendMetadata(driverInfo: DriverInfo) {
for (const info of this.options.additionalDriverInfo) {
if (info.name === driverInfo.name && info.version === driverInfo.version) {
return;
}
}
this.options.additionalDriverInfo.push(driverInfo);
this.options.metadata = makeClientMetadata(this.options);
this.options.extendedMetadata = addContainerMetadata(this.options.metadata)
Expand Down
13 changes: 13 additions & 0 deletions test/integration/mongodb-handshake/mongodb-handshake.prose.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,19 @@ describe('Client Metadata Update Prose Tests', function () {
// (Note os is the only one getting set in these tests)
expect(updatedClientMetadata.os).to.deep.equal(initialClientMetadata.os);
});

it('does not append duplicate metadata for the same name and version', async function () {
client.appendMetadata({ name, version, platform });
client.appendMetadata({ name, version, platform });
await client.db('test').command({ ping: 1 });
expect(updatedClientMetadata.driver.name).to.not.contain('|framework|framework');
});

it('appends metadata when the version differs', async function () {
client.appendMetadata({ name, version: '0.0', platform });
await client.db('test').command({ ping: 1 });
expect(updatedClientMetadata.driver.name).to.not.contain('0.0');
});
});
}
});
Expand Down