Skip to content

Conversation

durran
Copy link
Member

@durran durran commented Sep 9, 2025

Description

Updates AWS auth to use a custom credential provider first after URI/MongoClient credentials if present.

Summary of Changes

  • Custom credential provider now takes precedence over everything except URI, MongoClient credentials.
  • Adds additional prose tests.

What is the motivation for this change?

NODE-7047
NODE-6987

Release Highlight

Custom AWS Credential Provider Takes Highest Precedence

When providing a custom AWS credential provider via the auth mechanism property AWS_CREDENTIAL_PROVIDER, it will now take the highest precedence over any other AWS auth method, with the exception of URI parameters or credentials passed directly to the MongoClient.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran force-pushed the NODE-7047 branch 2 times, most recently from 1a59a5a to 6e98b5d Compare September 10, 2025 12:44
@durran durran marked this pull request as ready for review September 10, 2025 12:51
@durran durran requested a review from a team as a code owner September 10, 2025 12:51
@dariakp dariakp changed the title feat(NODE-7047): use custom credential provider first feat(NODE-7047)!: use custom credential provider first Sep 17, 2025
@durran durran force-pushed the NODE-7047 branch 3 times, most recently from 7281459 to 8271c1f Compare September 19, 2025 11:54
@durran durran changed the title feat(NODE-7047)!: use custom credential provider first feat(NODE-7047)!: use custom credential provider first after URI Sep 19, 2025
@baileympearson baileympearson self-assigned this Sep 19, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 19, 2025
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment in addition to Daria's comment

@baileympearson baileympearson dismissed dariakp’s stale review September 24, 2025 17:22

Comments addressed.

@baileympearson baileympearson merged commit 2a47bbb into main Sep 24, 2025
24 of 31 checks passed
@baileympearson baileympearson deleted the NODE-7047 branch September 24, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants