CLOUDP-278627: Update linting #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaangiolillo
approved these changes
Oct 30, 2024
| message: "'additionalServices' must be 'mms' as no other services are supported." | ||
|
|
||
| match: "^mms(,[a-zA-Z0-9_-]+)*$" | ||
| message: "'additionalServices' must start with 'mms' and can include additional services in a comma-separated format." |
There was a problem hiding this comment.
could you clarify this change? In which scenario we will have mms,service_name,ABC?
There was a problem hiding this comment.
as of now, we don't have other services, but SRE asked us to have this as a list and available for others. since I'm doing the PR for api-registry to return this, I'm adding some linting considering the comma separated names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-278627
Checklist
Changes to Spectral
Further comments