Skip to content

CLOUDP-278627: Update linting #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

CLOUDP-278627: Update linting #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tools/spectral/.spectral.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,8 @@ rules:
- field: additionalServices
function: pattern
functionOptions:
match: "^(mms)$"
message: "'additionalServices' must be 'mms' as no other services are supported."

match: "^mms(,[a-zA-Z0-9_-]+)*$"
message: "'additionalServices' must start with 'mms' and can include additional services in a comma-separated format."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you clarify this change? In which scenario we will have mms,service_name,ABC?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as of now, we don't have other services, but SRE asked us to have this as a list and available for others. since I'm doing the PR for api-registry to return this, I'm adding some linting considering the comma separated names

no-slash-before-custom-method:
description: "Custom methods (e.g., ':applyItem') should not be preceded by a '/'."
message: "The path '{{path}}' contains a '/' before a custom method. Custom methods should not start with a '/'."
Expand Down
Loading