Skip to content

CLOUDP-306579: IPA-124: Repeated Fields (fix) #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

CLOUDP-306579: IPA-124: Repeated Fields (fix) #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
528419b
CLOUDP-306579: IPA-124: Repeated Fields (fix)
yelizhenden-mdb Apr 4, 2025
c81747c
drive-by fix
yelizhenden-mdb Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/optional-spec-validations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,10 @@ jobs:
env: ${{ inputs.env }}
task_name: 'Optional Postman validation'
team_id: ${{ vars.JIRA_TEAM_ID_APIX_1 }}
secrets:
Copy link
Collaborator Author

@yelizhenden-mdb yelizhenden-mdb Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by fix: Jira API token is not needed for task-failure-handler. Will resolve the error thrown in the release workflow

jira_api_token: ${{ secrets.JIRA_API_TOKEN }}
- name: Create Issue - IPA validation Failed
if: ${{ failure() && steps.ipa-spectral-validation.outcome == 'failure'}}
uses: ./.github/workflows/task-failure-handler.yml
with:
env: ${{ inputs.env }}
task_name: 'Optional IPA validation'
team_id: ${{ vars.JIRA_TEAM_ID_APIX_1 }}
secrets:
jira_api_token: ${{ secrets.JIRA_API_TOKEN }}
9 changes: 9 additions & 0 deletions tools/spectral/ipa/__tests__/IPA124ArrayMaxItems.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,15 @@ testRule('xgen-IPA-124-array-max-items', [
type: 'object',
},
},
mapProperty: {
type: 'object',
additionalProperties: {
type: 'array',
items: {
type: 'string',
},
},
},
},
},
},
Expand Down
1 change: 1 addition & 0 deletions tools/spectral/ipa/rulesets/IPA-124.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@ rules:
ignore:
- links
- results
- additionalProperties
Loading