ci(ipa): make IPA metrics collection more efficient #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovisaberggren
commented
Sep 24, 2025
| } | ||
| } | ||
| console.log('\tMerging violations (total ' + violations.length + ')'); | ||
| const violationResults = violations.map((entry) => mapResults(entry, 'violated')); |
There was a problem hiding this comment.
Essentially, mapping the array to a new array using map() is faster than for-looping through the array and pushing each entry to a new array
lovisaberggren
changed the title
lovisaberggren
requested review from
andreaangiolillo,
drinkbird,
matt-condon,
wtrocki and
yelizhenden-mdb
matt-condon
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adjusted metrics collection logic to run faster/be more efficient. Now it runs in ~8 seconds locally. Previous GH action runs have been taking ~50 mins.
Jira ticket: CLOUDP-347215