Skip to content

ci(ipa): make IPA metrics collection more efficient #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

ci(ipa): make IPA metrics collection more efficient #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*.vscode
*.DS_Store

/tools/spectral/**/outputs/*
*.out
**/*ipa-collector-results-combined.log
**/*metric-collection-results.parquet
Expand Down
67 changes: 33 additions & 34 deletions tools/spectral/ipa/metrics/utils/metricCollectionUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,44 +53,43 @@ function getIPAFromIPARule(ipaRule) {
}

export function merge(ownershipData, collectorResults, ruleSeverityMap) {
const results = [];
function mapResults(entry, adoptionStatus) {
let ownerTeam = null;
if (entry.componentId.startsWith('paths')) {
const pathParts = entry.componentId.split('.');
if (pathParts.length === 2) {
const path = pathParts[1];
ownerTeam = ownershipData[path];
}
}

function addEntry(entryType, adoptionStatus) {
for (const entry of collectorResults[entryType]) {
const existing = results.find(
(result) => result.component_id === entry.componentId && result.ipa_rule === entry.ruleName
);
return {
component_id: entry.componentId,
ipa_rule: entry.ruleName,
ipa: getIPAFromIPARule(entry.ruleName),
severity_level: ruleSeverityMap[entry.ruleName],
adoption_status: adoptionStatus,
exception_reason: adoptionStatus === 'exempted' && entry.exceptionReason ? entry.exceptionReason : null,
owner_team: ownerTeam,
timestamp: new Date().toISOString(),
};
}

if (existing) {
console.warn('Duplicate entries found', existing);
continue;
}
const violations = collectorResults[EntryType.VIOLATION] || [];
const adoptions = collectorResults[EntryType.ADOPTION] || [];
const exceptions = collectorResults[EntryType.EXCEPTION] || [];

let ownerTeam = null;
if (entry.componentId.startsWith('paths')) {
const pathParts = entry.componentId.split('.');
if (pathParts.length === 2) {
const path = pathParts[1];
ownerTeam = ownershipData[path];
}
}
console.log('\tMerging violations (total ' + violations.length + ')');
const violationResults = violations.map((entry) => mapResults(entry, 'violated'));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially, mapping the array to a new array using map() is faster than for-looping through the array and pushing each entry to a new array


results.push({
component_id: entry.componentId,
ipa_rule: entry.ruleName,
ipa: getIPAFromIPARule(entry.ruleName),
severity_level: ruleSeverityMap[entry.ruleName],
adoption_status: adoptionStatus,
exception_reason: entryType === EntryType.EXCEPTION ? entry.exceptionReason : null,
owner_team: ownerTeam,
timestamp: new Date().toISOString(),
});
}
}
console.log('\tMerging adoptions (total ' + adoptions.length + ')');
const adoptionResults = adoptions.map((entry) => mapResults(entry, 'adopted'));

addEntry(EntryType.VIOLATION, 'violated');
addEntry(EntryType.ADOPTION, 'adopted');
addEntry(EntryType.EXCEPTION, 'exempted');
console.log('\tMerging exceptions (total ' + exceptions.length + ')');
const exceptionResults = exceptions.map((entry) => mapResults(entry, 'exempted'));

return results;
console.log(
'\tMerging complete. Total entries: ' + (violationResults.length + adoptionResults.length + exceptionResults.length)
);
return [...violationResults, ...adoptionResults, ...exceptionResults];
}
Loading