-
Notifications
You must be signed in to change notification settings - Fork 246
DRIVERS-3131: No explicitly provided properties with MONGODB-AWS #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
durran
wants to merge
11
commits into
master
Choose a base branch
from
DRIVERS-3131
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
30808eb
DRIVERS-3131: No URI credentials with MONGODB-AWS
durran 8ed234a
fix: lint
durran 51184d3
chore: add note on error cases
durran df19d50
fix: lint
durran 8a8ecaf
chore: comments
durran 6633b5a
chore: comments
durran aad1e8a
fix: lint
durran 7714280
chore: comments
durran 714e051
chore: comments
durran 1780f54
test: fix tests
durran bd28f1f
chore: last removal
durran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -320,6 +320,15 @@ tests: | |
mechanism: MONGODB-AWS | ||
mechanism_properties: | ||
AWS_SESSION_TOKEN: token!@#$%^&*()_+ | ||
- description: should throw an exception if username provided (MONGODB-AWS) | ||
uri: mongodb://[email protected]/?authMechanism=MONGODB-AWS | ||
valid: false | ||
- description: should throw an exception if username and password provided (MONGODB-AWS) | ||
uri: mongodb://user:[email protected]/?authMechanism=MONGODB-AWS | ||
valid: false | ||
- description: should throw an exception if AWS_SESSION_TOKEN provided (MONGODB-AWS) | ||
uri: mongodb://localhost/?authMechanism=MONGODB-AWS&authMechanismProperties=AWS_SESSION_TOKEN:token | ||
valid: false | ||
- description: should recognise the mechanism with test environment (MONGODB-OIDC) | ||
uri: mongodb://localhost/?authMechanism=MONGODB-OIDC&authMechanismProperties=ENVIRONMENT:test | ||
valid: true | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we still want to test this with env vars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is now fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you by any chance forget to push this change?