DRIVERS-3131: No explicitly provided properties with MONGODB-AWS #1847
Conversation
durran
force-pushed
the
DRIVERS-3131
branch
from
cb6a6eb to
30808eb
Compare
| mongodb://<AccessKeyId>:<SecretAccessKey>@localhost/?authMechanism=MONGODB-AWS | ||
| mongodb://localhost/?authMechanism=MONGODB-AWS | ||
| ``` | ||
|
|
There was a problem hiding this comment.
We should also update the other prose tests that are no longer relevant in this file (strike-through, or replace the title with *Removed* per prose test guidelines)
There was a problem hiding this comment.
All the the prose tests are still valid and I updated the assume role test to note as well to pass --nouri
There was a problem hiding this comment.
I believe Case 1 above would fall into the category of "no longer relevant" after this set of changes, so I was suggesting the strike-through method. There is also a callout about URI encoding in L15-16 of this file that should probably be amended.
There was a problem hiding this comment.
I've added the Removed label to the titles.
There was a problem hiding this comment.
I don't think those are the tests we want to remove. In addition, the guidelines for removing tests say to either remove the whole test and replace the title with "Removed" OR strikethrough the entire content - just adding a "removed" label and keeping everything else in place might be confusing.
dariakp
changed the title
| mongodb://<AccessKeyId>:<SecretAccessKey>@localhost/?authMechanism=MONGODB-AWS | ||
| mongodb://localhost/?authMechanism=MONGODB-AWS | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I believe Case 1 above would fall into the category of "no longer relevant" after this set of changes, so I was suggesting the strike-through method. There is also a callout about URI encoding in L15-16 of this file that should probably be amended.
| Drivers MUST test the following scenarios: | ||
|
|
||
| 1. `Regular Credentials`: Auth via an `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` pair | ||
| 1. `Regular Credentials`: Auth via an `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` pair *Removed* |
There was a problem hiding this comment.
Don't we still want to test this with env vars?
source/auth/tests/mongodb-aws.md
Outdated
| Expect authentication to succeed and the custom credential provider was called. | ||
|
|
||
| ## Regular credentials | ||
| ## Regular credentials *Removed* |
There was a problem hiding this comment.
I don't think this is the right test to remove, #### Case 1: Credentials in URI Take Precedence is the one that isn't relevant with the new changes.
| mongodb://<AccessKeyId>:<SecretAccessKey>@localhost/?authMechanism=MONGODB-AWS | ||
| mongodb://localhost/?authMechanism=MONGODB-AWS | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I don't think those are the tests we want to remove. In addition, the guidelines for removing tests say to either remove the whole test and replace the title with "Removed" OR strikethrough the entire content - just adding a "removed" label and keeping everything else in place might be confusing.
|
This has been fixed. |
Removes supplying credentials for MONGODB-AWS in the URI or client options in the auth spec and adds new tests.
Tools changes: mongodb-labs/drivers-evergreen-tools#691
Node implementation: mongodb/node-mongodb-native#4689
Please complete the following before merging:
clusters).