-
Notifications
You must be signed in to change notification settings - Fork 246
DRIVERS-3131: No explicitly provided properties with MONGODB-AWS #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 7 commits
30808eb
8ed234a
51184d3
df19d50
8a8ecaf
6633b5a
aad1e8a
7714280
714e051
1780f54
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,11 +59,11 @@ Expect authentication to succeed and the custom credential provider was called. | |
|
||
## Regular credentials | ||
|
||
Drivers MUST be able to authenticate by providing a valid access key id and secret access key pair as the username and | ||
password, respectively, in the MongoDB URI. An example of a valid URI would be: | ||
Drivers MUST be able to authenticate when a valid access key id and secret access key pair are present in the | ||
environment. Drivers MUST provide the --nouri option to aws_tester.py in drivers-evergreen-tools for this test. | ||
|
||
```text | ||
mongodb://<AccessKeyId>:<SecretAccessKey>@localhost/?authMechanism=MONGODB-AWS | ||
mongodb://localhost/?authMechanism=MONGODB-AWS | ||
``` | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should also update the other prose tests that are no longer relevant in this file (strike-through, or replace the title with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All the the prose tests are still valid and I updated the assume role test to note as well to pass --nouri There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe Case 1 above would fall into the category of "no longer relevant" after this set of changes, so I was suggesting the strike-through method. There is also a callout about URI encoding in L15-16 of this file that should probably be amended. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've added the Removed label to the titles. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think those are the tests we want to remove. In addition, the guidelines for removing tests say to either remove the whole test and replace the title with "Removed" OR strikethrough the entire content - just adding a "removed" label and keeping everything else in place might be confusing. |
||
## EC2 Credentials | ||
|
@@ -95,11 +95,11 @@ mongodb://localhost/?authMechanism=MONGODB-AWS | |
## AssumeRole | ||
|
||
Drivers MUST be able to authenticate using temporary credentials returned from an assume role request. These temporary | ||
credentials consist of an access key ID, a secret access key, and a security token passed into the URI. A sample URI | ||
would be: | ||
credentials consist of an access key ID, a secret access key, and a security token passed into the URI. Drivers MUST | ||
dariakp marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
provide the --nouri option to aws_tester.py in drivers-evergreen-tools for this test. A sample URI would be: | ||
|
||
```text | ||
mongodb://<AccessKeyId>:<SecretAccessKey>@localhost/?authMechanism=MONGODB-AWS&authMechanismProperties=AWS_SESSION_TOKEN:<Token> | ||
mongodb://localhost/?authMechanism=MONGODB-AWS | ||
``` | ||
|
||
## Assume Role with Web Identity | ||
|
Uh oh!
There was an error while loading. Please reload this page.