Skip to content

Remove serialization of GcResource to MXML files #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monkeyman192 merged 1 commit into from
Oct 29, 2025
Merged

Remove serialization of GcResource to MXML files #678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libMBIN/Source/Template/NMSTemplate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,6 +1243,10 @@ public MXmlBase SerializeMXmlValue(Type fieldType, FieldInfo field, NMSAttribute
GcSeed seed = (GcSeed)value;
valueString = (seed.Seed == 0 && !seed.UseSeedValue) ? "NONE" : seed.Seed.ToString();
break;
case "GcResource":
// Don't return anything. We won't write this to MXML since the data is only used internally
// and isn't serialized by the game either.
return null;
case "Colour32":
// Handle the Colour32 explicitly since we want to write floats to the MXML, not ints.
Colour colour = new Colour((Colour32)value);
Expand Down
Loading