Skip to content

fix(custom): ignore prototype properties in British English replacement rules (@byseif21) #7317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 1 commit into from
Jan 6, 2026
Merged

fix(custom): ignore prototype properties in British English replacement rules (@byseif21) #7317

Miodec merged 1 commit into from
Jan 6, 2026
+8 −0

Conversation

@byseif21
Copy link
Contributor

@byseif21 byseif21 commented Jan 6, 2026

Description

  • custom mode (with british english enabled) could break with some words that matched an inherited JS object property, causing crashes
  • made the replacement logic now ignores prototype property names on the rules object, added a small test for it.

Closes #7316

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jan 6, 2026
@Miodec Miodec merged commit 0c168af into monkeytypegame:master Jan 6, 2026
13 checks passed
@Miodec
Copy link
Member

Miodec commented Jan 6, 2026

Thanks

@byseif21 byseif21 deleted the fix/b-english-replace-rules branch January 7, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

frontend User interface or web stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom test with the word "Constructor" fails to create

3 participants

@byseif21 @Miodec @monkeytypegeorge