Skip to content

fix(custom): ignore prototype properties in British English replacement rules (@byseif21) #7317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miodec merged 1 commit into from
Jan 6, 2026
+8 −0
Merged

fix(custom): ignore prototype properties in British English replacement rules (@byseif21) #7317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/__tests__/test/british-english.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,10 @@ describe("british-english", () => {
await expect(replace("'hello'", "")).resolves.toEqual("'hello'");
await expect(replace("test", "")).resolves.toEqual("test");
});

it("ignores prototype-related property names (e.g. constructor, __proto__)", async () => {
await expect(replace("constructor", "")).resolves.toEqual("constructor");
await expect(replace("__proto__", "")).resolves.toEqual("__proto__");
});
});
});
3 changes: 3 additions & 0 deletions frontend/src/ts/test/british-english.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,9 @@ export async function replace(
).join("-");
} else {
const cleanedWord = word.replace(/^[\W]+|[\W]+$/g, "").toLowerCase();
if (!Object.prototype.hasOwnProperty.call(replacementRules, cleanedWord)) {
return word;
}
const rule = replacementRules[cleanedWord];

if (rule === undefined) return word;
Expand Down