Skip to content

Добавить в WS3 функции прописи чисел и дат на казахском 2 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Erasiloco wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Добавить в WS3 функции прописи чисел и дат на казахском 2 #27

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8444e3d
string to DateTime
Erasiloco Jul 16, 2020
bdb608a
GetDate
Erasiloco Jul 17, 2020
413f500
added exception and try catch blocks
Erasiloco Jul 20, 2020
c09b618
Get Date try catch
Erasiloco Jul 20, 2020
4895936
added constructor with ErrorCode into BadRequestException
Erasiloco Jul 20, 2020
df262ba
Add XML comment for GetOrdinal
bzaar Jul 24, 2020
fc501ad
Сервис умеет строить пропись для всех значений типа long.
Erasiloco Jul 25, 2020
9b63c18
Error-Code
Erasiloco Jul 25, 2020
f559d45
comments
Erasiloco Jul 25, 2020
2cf8497
parse response content
Erasiloco Jul 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Morpher.WebService.V3.Client/Qazaq/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ public string GetOrdinal(string cardinal)
}
}

public string GetDate(string date, bool useOne)
public string GetDate(DateTime dateTime, bool useOne)
Copy link
Member

@bzaar bzaar Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уже была выпущена версия с этим методом. Если его изменить, то поломается обратная совместимость. Лучше добавить новый метод (перегрузку) с параметром DateTime, а этот пометить как Obsolete.

{
using (var client = _newClient())
{
client.AddParam("date", date);
client.AddParam("date", dateTime.ToString());
Copy link
Member

@bzaar bzaar Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно отформатировать дату. Иначе можешь получить что-нибудь вроде "21. Juni 2020" в зависимости от региональных настроек ОС.

client.AddParam("use-one", useOne.ToString());
var stringResult = client.GetObject<string>("/qazaq/date");

Expand Down