Skip to content

Use ament_cmake_ros build tool in moveit_setup_assistant packages#3441

Merged
sjahr merged 5 commits intomainfrom
msframework-buildtool-fix
Apr 15, 2025
Merged

Use ament_cmake_ros build tool in moveit_setup_assistant packages#3441
sjahr merged 5 commits intomainfrom
msframework-buildtool-fix

Conversation

@sea-bass
Copy link
Copy Markdown
Contributor

@sea-bass sea-bass commented Apr 14, 2025

Description

Something changed in rolling apparently, so buildfarm is not happy.

Closes #3440

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass changed the title Use ament_cpp_ros build tool in moveit_setup_framework Use ament_cpp_ros build tool in moveit_setup_assistant packages Apr 14, 2025
@sea-bass sea-bass changed the title Use ament_cpp_ros build tool in moveit_setup_assistant packages Use ament_cmake_ros build tool in moveit_setup_assistant packages Apr 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.86%. Comparing base (ec5b368) to head (8d0039e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3441      +/-   ##
==========================================
+ Coverage   45.84%   45.86%   +0.02%     
==========================================
  Files         717      717              
  Lines       62637    62637              
  Branches     7581     7581              
==========================================
+ Hits        28712    28722      +10     
+ Misses      33757    33747      -10     
  Partials      168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sjahr sjahr merged commit c340713 into main Apr 15, 2025
16 of 17 checks passed
@sjahr sjahr deleted the msframework-buildtool-fix branch April 15, 2025 08:05
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Apr 15, 2025
Markus-Simonsen pushed a commit to Markus-Simonsen/moveit2 that referenced this pull request Aug 12, 2025
helen9975 pushed a commit to personalrobotics/moveit2 that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression on ROS 2 Buildfarm for Rolling

2 participants