feat: deprecate ggp and add e2e tests to check for correct gas collection using collect_fee #1295
Conversation
0xIcarus
changed the title
| process-compose -f process-compose/movement-full-node/process-compose.test-e2e-verify-collect-fee.yml up --wait --follow | ||
|
|
||
| test-e2e-framework-upgrade-collect-gas-fees: | ||
| process-compose -f process-compose/movement-full-node/process-compose.test-e2e-framework-upgrade-collect-gas-fees.yml up --wait --follow |
There was a problem hiding this comment.
You can remove this. E2E tests require a full-node setup and faucet. We are probably going to run it with
just movement-full-node native build.setup.test-e2e-verify-collect-fee
just movement-full-node native build.setup.
test-e2e-framework-upgrade-collect-gas-fees
| format!("unknown release string: {}", release).into(), | ||
| ) | ||
| .into()), | ||
| } |
There was a problem hiding this comment.
The code formatting is off.
| faucet_client | ||
| .create_account(beneficiary.address()) | ||
| .await | ||
| .context("Failed to create beneficiary account via faucet")?; |
There was a problem hiding this comment.
On mainnet there's no faucet. You test for the sender, but not for the beneficiary? I think this call fail on mainnet. I think you don't need to create the account to send it some token.
Another remarks, you should send less than 1000 move because on mainnet they will be lost. Beneficiary is a random generated account.
In fact, you don't expect to run the test on mainnet so we don't verify the change work well on mainnet in this case. Perhaps during the migration we should test these change apply correctly. I add some strange issue with the epoch duration change where I got different behavior depending on the network.
So passing the test on a mainnet fork should be a good thing, but in this case you don't care the token amount. I'll try to pass it on a mainnet fork.
| genesis.set_sequence_number(acct.inner().sequence_number); | ||
| } | ||
| let txh = coin_client | ||
| .transfer(&mut genesis, sender.address(), 1_000_000, None) |
There was a problem hiding this comment.
Use less move they will be lost in mainnet.
|
I've tested to update mainnet db. The |
0xIcarus
force-pushed
the
0xIcarus/ggp-deprecate
branch
from
a7b7117 to
14c952a
Compare
Summary
networks,misc.Deprecating governed gas pool and replacing gas collection logic with
transaction_fee::collect_feemodule using a fw upgrade. Added e2e tests to confirm deprecation and correct fee collection values and to query for the module on chain.Changelog
0xIcarus/ggp-deprecateonmovementlabsxyz/aptos-coreto allow featureCOLLECT_AND_DISTRIBUTE_GAS_FEESto be voted through.Testing
New e2e tests added to verify if fee collection behavior matches expectations
Run using
nix develop --command bash -c "just movement-full-node native build.setup.test-e2e-verify-collect-fee --keep-project"Outstanding issues