Skip to content

feat: deprecate ggp and add e2e tests to check for correct gas collection using collect_fee #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: deprecate ggp and add e2e tests to check for correct gas collection using collect_fee #1295

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
343fd34
feat: use aptos-core commit hash with correct prerequisite functions
0xIcarus Jul 30, 2025
bea859c
feat: e2e tests to check if feature flag is enabled and if gas collec…
0xIcarus Aug 13, 2025
259c80b
feat: update funding method and added simple check for deprecation
0xIcarus Aug 26, 2025
82d10ce
fix: fix unable to find account error before txn
0xIcarus Aug 26, 2025
93bbfe1
fix: rollback to funding using testnet
0xIcarus Aug 26, 2025
f01a3af
feat: use local faucet for funding
0xIcarus Aug 28, 2025
14c952a
feat: use local faucet and update setup to match other e2e tests
0xIcarus Aug 28, 2025
517f606
feat: update to use less than 1000 move in tests
0xIcarus Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ aptos-framework-head-release = { path = "protocol-units/execution/maptos/framewo
aptos-framework-elsa-release = { path = "protocol-units/execution/maptos/framework/releases/elsa" }
aptos-framework-biarritz-rc1-release = { path = "protocol-units/execution/maptos/framework/releases/biarritz-rc1" }
aptos-framework-pre-l1-merge-release = { path = "protocol-units/execution/maptos/framework/releases/pre-l1-merge" }
aptos-framework-pre-l1-merge-reset-release = { path = "protocol-units/execution/maptos/framework/releases/pre-l1-merge-reset" }
aptos-framework-upgrade-gas-release = { path = "protocol-units/execution/maptos/framework/releases/upgrade-gas" }
aptos-framework-known-release = { path = "protocol-units/execution/maptos/framework/releases/known-release" }
aptos-framework-set-feature-flags-release = { path = "protocol-units/execution/maptos/framework/releases/feature-flags" }
Expand Down
7 changes: 7 additions & 0 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,10 @@ build-push-container IMAGE:
./scripts/movement/build-push-image {{ IMAGE }}
container-tests:
./scripts/tests/container-tests

# E2E Tests for GGP Deprecation
test-e2e-verify-collect-fee:
process-compose -f process-compose/movement-full-node/process-compose.test-e2e-verify-collect-fee.yml up --wait --follow

test-e2e-framework-upgrade-collect-gas-fees:
process-compose -f process-compose/movement-full-node/process-compose.test-e2e-framework-upgrade-collect-gas-fees.yml up --wait --follow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this. E2E tests require a full-node setup and faucet. We are probably going to run it with

 just movement-full-node native build.setup.test-e2e-verify-collect-fee
 just movement-full-node native build.setup.
test-e2e-framework-upgrade-collect-gas-fees

4 changes: 4 additions & 0 deletions networks/movement/movement-client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ path = "src/bin/e2e/whitelist.rs"
name = "movement-tests-e2e-ggp-gas-fee"
path = "src/bin/e2e/ggp_gas_fee.rs"

[[bin]]
name = "e2e_ggp_deprecation"
path = "src/bin/e2e/e2e_ggp_deprecation.rs"

[[bin]]
name = "movement-tests-e2e-transfer"
path = "src/bin/e2e/transfer.rs"
Expand Down
Loading
Loading