Skip to content

workflows: don't add TARGET_BRANCH if LANDO_REPO specified in repo variables (bug 1996664)#745

Closed
shtrom wants to merge 2 commits intomainfrom
bug1996664/workflow-lando-link-full-override
Closed

workflows: don't add TARGET_BRANCH if LANDO_REPO specified in repo variables (bug 1996664)#745
shtrom wants to merge 2 commits intomainfrom
bug1996664/workflow-lando-link-full-override

Conversation

@shtrom
Copy link
Member

@shtrom shtrom commented Dec 5, 2025

No description provided.

@shtrom shtrom requested a review from zzzeid December 5, 2025 00:06
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

View this pull request in Lando to land it once approved.

@shtrom shtrom marked this pull request as ready for review December 5, 2025 00:06
@shtrom shtrom requested a review from cgsheeh December 5, 2025 00:25
Copy link
Contributor

@zzzeid zzzeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: historically we used workflows in the commit title to more easily identify changes to workflows.

I'm wondering if there's a better way to do this in the long term. Maybe we can have a (cached) endpoint in Lando that takes a repo/branch combination and returns the Lando repo name.

@shtrom shtrom changed the title pr-handler: don't add TARGET_BRANCH if LANDO_REPO specified in repo variables (bug 1996664) workflows: don't add TARGET_BRANCH if LANDO_REPO specified in repo variables (bug 1996664) Dec 8, 2025
@lando-prod-mozilla
Copy link

Pull request closed by commit a1eb72f

lando-prod-mozilla bot pushed a commit that referenced this pull request Dec 8, 2025
@shtrom shtrom deleted the bug1996664/workflow-lando-link-full-override branch January 22, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants