Skip to content

workflows: don't add TARGET_BRANCH if LANDO_REPO specified in repo variables (bug 1996664) #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shtrom wants to merge 2 commits into from
Closed

workflows: don't add TARGET_BRANCH if LANDO_REPO specified in repo variables (bug 1996664) #745

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c908615
pr-handler: don't add TARGET_BRANCH if LANDO_REPO specified in repo v…
shtrom Dec 5, 2025
c1a0605
Apply suggestion from @shtrom
shtrom Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pr-handler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
TARGET_BRANCH: ${{ github.base_ref}}
run: |
LANDO_BASE_URL="${LANDO_BASE_URL:-${DEFAULT_LANDO_BASE_URL}}"
# We extract the GitHub repo name to use as default LANDO_REPO if
# unspecified.
LANDO_REPO="${LANDO_REPO:-${GITHUB_REPO/*\//}}-${TARGET_BRANCH}"
# We extract the GitHub repo name and target branch to use as
# default LANDO_REPO if unspecified.
LANDO_REPO="${LANDO_REPO:-${GITHUB_REPO/*\//}-${TARGET_BRANCH}}"
gh pr comment "${PR}" --body "[View this pull request in Lando](${LANDO_BASE_URL}/pulls/${LANDO_REPO}/${PR}) to land it once approved."