api.views: add try push handover functionality (bug 2002566)#748
Closed
api.views: add try push handover functionality (bug 2002566)#748
Conversation
|
View this pull request in Lando to land it once approved. |
zzzeid
force-pushed
the
zeid/bug-2002566-try-push-lando-github
branch
from
6c48e2b to
9af2c90
Compare
zzzeid
commented
Dec 5, 2025
zzzeid
commented
Dec 5, 2025
zzzeid
commented
Dec 5, 2025
zzzeid
commented
Dec 5, 2025
zzzeid
force-pushed
the
zeid/bug-2002566-try-push-lando-github
branch
2 times, most recently
from
57bb01e to
717edd9
Compare
zzzeid
changed the base branch from
main
to
zeid/bug-2004764-pull-request-job
zzzeid
force-pushed
the
zeid/bug-2002566-try-push-lando-github
branch
2 times, most recently
from
b2e9d18 to
6c55a61
Compare
shtrom
reviewed
Dec 9, 2025
La0
reviewed
Dec 11, 2025
zzzeid
force-pushed
the
zeid/bug-2004764-pull-request-job
branch
from
52b5e9a to
6f7a47b
Compare
zzzeid
force-pushed
the
zeid/bug-2002566-try-push-lando-github
branch
2 times, most recently
from
851f024 to
04b776f
Compare
zzzeid
changed the base branch from
zeid/bug-2004764-pull-request-job
to
zeid/bug-2005795-pr-head-sha
zzzeid
force-pushed
the
zeid/bug-2002566-try-push-lando-github
branch
3 times, most recently
from
10cb656 to
dca860f
Compare
zzzeid
force-pushed
the
zeid/bug-2005795-pr-head-sha
branch
from
589ca64 to
dfc58bd
Compare
zzzeid
force-pushed
the
zeid/bug-2002566-try-push-lando-github
branch
from
dca860f to
5c08094
Compare
shtrom
reviewed
Dec 16, 2025
Member
shtrom
left a comment
shtrom
left a comment
There was a problem hiding this comment.
A couple of small nits, but this is looking good to me.
Comment on lines
+332
to
+337
| patch_data = { | ||
| "author_name": author_name, | ||
| "author_email": author_email, | ||
| "commit_message": pull_request.commit_message, | ||
| "timestamp": int(datetime.now().timestamp()), | ||
| } |
Member
There was a problem hiding this comment.
note for later: We've been building this often enough, we should make it a method of the PullRequest.
zzzeid
force-pushed
the
zeid/bug-2005795-pr-head-sha
branch
from
dfc58bd to
8b10be0
Compare
shtrom
approved these changes
Dec 17, 2025
Member
shtrom
left a comment
shtrom
left a comment
There was a problem hiding this comment.
lgtm. As a nit, I'd rather not change the name of scm.get_diff_from_patches, but we're good to go in otherwise.
|
|
||
| @detect_patch_conflict | ||
| def get_diff_from_patches(self, patches: str) -> str: | ||
| def add_diff_from_patches(self, patches: str) -> str: |
Member
There was a problem hiding this comment.
What motivates the change in name? We do a git add in the working directory, but ultimately this is transient, as it's only for the purpose of returning a diff string to the caller.
zzzeid
force-pushed
the
zeid/bug-2005795-pr-head-sha
branch
from
8b10be0 to
dc151a8
Compare
La0
reviewed
Dec 18, 2025
| data = { | ||
| "parameters": { | ||
| "optimize_target_tasks": True, | ||
| "target_tasks_method": "codereview", |
Contributor
There was a problem hiding this comment.
If this firefox patch is approved, you'll be able to pass all the kwargs in try_task_config parameter.
Your payload should look like:
data {
"parameters": {
"optimize_target_tasks": true,
"target_tasks_method": "codereview",
"try_mode": "try_task_config",
"try_task_config": { f"github_{k}": v for k, v in kwargs.items()}
}
},
"version": 2
}
Contributor
Author
There was a problem hiding this comment.
Ok, I am going to move these changes to their own PR so that this one can be merged before the schema is finalized. Will update with your suggestion in that other PR.
- add functionality that adds try_task_config.json file - update landing worker to process handover jobs - add PullRequestTryLintAPIView - add LandingJob.handover_repo field and migrations - add LandingJob.is_handed_over field and migrations - add Repo.is_try helper method
zzzeid
force-pushed
the
zeid/bug-2002566-try-push-lando-github
branch
from
537201b to
f194760
Compare
lando-prod-mozilla bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
- add functionality that adds try_task_config.json file - update landing worker to process handover jobs - add PullRequestTryLintAPIView - add LandingJob.handover_repo field and migrations - add LandingJob.is_handed_over field and migrations - add Repo.is_try helper method Pull request: #748
|
Pull request closed by commit f8c53f3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.