Closed
Conversation
Contributor
zzzeid
commented
Feb 25, 2026
zzzeid
commented
- add pull_head_sha to try_task_config.json
- add csrf_exempt decorator to endpoint
- add pull_head_sha to try_task_config.json - add csrf_exempt decorator to endpoint
|
View this pull request in Lando to land it once approved. |
shtrom
reviewed
Feb 26, 2026
| return JsonResponse(warnings_and_blockers) | ||
|
|
||
|
|
||
| @method_decorator(csrf_exempt, name="dispatch") |
Member
There was a problem hiding this comment.
nit: It may actually make sense to keep the CSRF here.
Unless we want others than the PR view page to be able to create a try job?
Contributor
Author
There was a problem hiding this comment.
Yeah this is added so that external services (e.g., code-review-bot) can use this endpoint. I think since we require an authenticated user for all requests to this endpoint, we should be OK.
shtrom
approved these changes
Feb 26, 2026
Member
shtrom
left a comment
shtrom
left a comment
There was a problem hiding this comment.
Questions on CSRF removal, but LGTM otherwise.
|
Pull request closed by commit 8ab6849 |
lando-prod-mozilla bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
- add pull_head_sha to try_task_config.json - add csrf_exempt decorator to endpoint Pull request: #948
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.