Skip to content

api.views: try handover fixes (bug 2019417) #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zzzeid wants to merge 1 commit into from
Closed

api.views: try handover fixes (bug 2019417) #948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lando/api/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ def get(self, request: WSGIRequest, repo_name: str, number: int) -> JsonResponse
return JsonResponse(warnings_and_blockers)


@method_decorator(csrf_exempt, name="dispatch")
Copy link
Member

@shtrom shtrom Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It may actually make sense to keep the CSRF here.

Unless we want others than the PR view page to be able to create a try job?

Copy link
Contributor Author

@zzzeid zzzeid Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is added so that external services (e.g., code-review-bot) can use this endpoint. I think since we require an authenticated user for all requests to this endpoint, we should be OK.

class PullRequestTryPushAPIView(APIView):
@method_decorator(require_authenticated_user)
def post(
Expand Down Expand Up @@ -343,6 +344,7 @@ def post(
}
revision = Revision.objects.create(
pull_number=pull_request.number,
pull_head_sha=pull_request.head_sha,
patches=pull_request.patch,
patch_data=patch_data,
)
Expand Down