admin: provide links back to public job and revision pages (bug 2019494)#952
admin: provide links back to public job and revision pages (bug 2019494)#952
Conversation
|
View this pull request in Lando to land it once approved. |
shtrom
changed the base branch from
main
to
bug2019496/dev-admin-profile-fix
shtrom
changed the title
| def view_on_site(self, instance: Revision) -> str | None: | ||
| if not instance.revision_id: | ||
| return None | ||
| url = reverse("revisions-page", kwargs={"revision_id": instance.revision_id}) | ||
| return url | ||
|
|
There was a problem hiding this comment.
Might as well implement this for a pull request based revision?
There was a problem hiding this comment.
Do we have a dedicated Lando page for those yet?
There was a problem hiding this comment.
Ok, I had a look, and we could link it to the pull-request view via the pull_number on the Revision, but we also need a repo_name, which I think is only associated to the revision via a LandingJob, so I don't think we have enough information to link.
Can you think of another way to get it?
There was a problem hiding this comment.
It may actually make more sense to complete the model to have a pull_repo[_name], because a pull_number in isolation is a bit meaningless. We may also want to add a is_pull_request?
There was a problem hiding this comment.
Ok, I'm gonna land this as is, but we should follow up with adding support for PRs. Added a note here: https://bugzilla.mozilla.org/show_bug.cgi?id=2012875#c4
shtrom
force-pushed
the
bug2019488/admin-backlinks
branch
from
b4bfab6 to
acfb4ca
Compare
|
dropped the admin profile commit from #951. |
|
Pull request closed by commit ecf3c3e |
…88) r=sheehan,zeid Pull request: #952
shtrom
changed the title
3 participants
Original bug 2019488 (in landed commit) is incorrect, it should be bug 2019494.