Conversation
Because: - We now have a dedicated, shared library for rendering email templates - The .ftl files are contained in this library - We've started using them, and are actively porting the strings from auth.ftl into emails.ftl. This Commit: - Updates scripts to export l10n strings to emails.ftl - Updates CI to run extraction on email-renderer lib
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This Commit:
Notes
I've validated the CI runs, but had commented out the line that issued the actual PR to avoid any confusion. The line that creates the PR has been reintroduced, so when we review this, we should run the action once more, and then audit the PR it creates.
Here's the successful run sans PR. https://github.com/mozilla/fxa-content-server-l10n/actions/runs/21726817887