Skip to content

fix(google_gke_tenant): updated gcp_sa_name variable to use name instead of email #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(google_gke_tenant): updated gcp_sa_name variable to use name instead of email #286

wants to merge 2 commits into from

Conversation

@dlactin
Copy link
Contributor

@dlactin dlactin commented Apr 10, 2025

Changelog entry

* Using service account name in `gcp_sa_name` variable and populating `gcp_sa_email` for existing service accounts

Requires changes in #285

@dlactin dlactin added the major This PR will increment a major version label Apr 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

Release plan

Directory Previous version New version
google_gke_tenant 0.0.0 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonthomas jasonthomas Awaiting requested review from jasonthomas jasonthomas is a code owner

@jbuck jbuck Awaiting requested review from jbuck jbuck is a code owner

@bkochendorfer bkochendorfer Awaiting requested review from bkochendorfer bkochendorfer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

major This PR will increment a major version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlactin