Skip to content

fix(google_gke_tenant): updated gcp_sa_name variable to use name instead of email #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(google_gke_tenant): updated gcp_sa_name variable to use name instead of email #286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56bb112
fix(google_gke_tenant): updated gcp_sa_name variable to use name inst…
dlactin Apr 10, 2025
123357f
fix(google_gke_tenant): providing gcp_sa_email for existing service a…
dlactin Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions google_gke_tenant/gke_service_account.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ module "workload-identity-for-tenant-sa" {
project_id = var.cluster_project_id
use_existing_k8s_sa = true
use_existing_gcp_sa = true
gcp_sa_name = google_service_account.gke-account.email
gcp_sa_name = google_service_account.gke-account.name
gcp_sa_email = google_service_account.gke-account.email
}

module "workload-identity-for-generic-tenant-sa" {
Expand All @@ -23,7 +24,8 @@ module "workload-identity-for-generic-tenant-sa" {
project_id = var.cluster_project_id
use_existing_k8s_sa = true
use_existing_gcp_sa = true
gcp_sa_name = google_service_account.gke-account.email
gcp_sa_name = google_service_account.gke-account.name
gcp_sa_email = google_service_account.gke-account.email
}

module "workload-identity-for-tenant-external-secrets-sa" {
Expand All @@ -34,7 +36,8 @@ module "workload-identity-for-tenant-external-secrets-sa" {
project_id = var.cluster_project_id
use_existing_k8s_sa = true
use_existing_gcp_sa = true
gcp_sa_name = google_service_account.gke-account.email
gcp_sa_name = google_service_account.gke-account.name
gcp_sa_email = google_service_account.gke-account.email
}

# permissions for use with External Secrets Operator in GKE
Expand Down
Loading