Skip to content

ao_pipewire: revert cubic volume curves, update docs #17703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
winex wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −4
Open

ao_pipewire: revert cubic volume curves, update docs #17703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1316097
DOCS/man/input: clarify `ao-volume` works the same way with PipeWire
winex Apr 5, 2026
1293e40
Revert "ao_pipewire: pipewire uses linear volume"
winex Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DOCS/man/input.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2699,8 +2699,8 @@ Property list
currently active, and only if the underlying implementation supports volume
control. What this option does, or how the value is interpreted depends on
the API. For example, on ALSA this usually changes system-wide audio volume
on a linear curve, while with PulseAudio this controls per-application volume
on a cubic curve.
on a linear curve, while with PipeWire and PulseAudio this controls
per-application volume on a cubic curve.

``ao-mute`` (RW)
Similar to ``ao-volume``, but controls the mute state. May be unimplemented
Expand Down
5 changes: 3 additions & 2 deletions audio/out/ao_pipewire.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,12 +273,13 @@ static void on_state_changed(void *userdata, enum pw_stream_state old, enum pw_s

static float spa_volume_to_mp_volume(float vol)
{
return vol * 100;
return cbrt(vol) * 100;
}

static float mp_volume_to_spa_volume(float vol)
{
return vol / 100;
vol /= 100;
return vol * vol * vol;
}

static float volume_avg(float* vols, uint32_t n)
Expand Down
Loading