dts: msm8952: Add support for Huawei Honor 7A Pro #604
Conversation
artempeshkov
force-pushed
the
main
branch
3 times, most recently
from
efb043c to
8003f27
Compare
| lk2nd,match-panel; | ||
|
|
||
| lk2nd,dtb-files = "msm8937-huawei-aum"; | ||
| lk2nd,dtb-files = "msm8937-huawei-autumn-l41"; |
There was a problem hiding this comment.
Could you provide the link to where this device tree is, which explains why you have changed this line?
There was a problem hiding this comment.
There is no such device tree in mainline yet, but, I changed it because there are two models with different hardware with the codename "autumn": AUM-L29 and AUM-L41, so they will need to have different mainline dtbs, and because aum is not the actual codename of these models.
There was a problem hiding this comment.
The mainline device trees matters, so I am afraid that splitting them is not much point there to do so.
Single msm8937-huawei-autumn should be all we need at the moment.
There was a problem hiding this comment.
Changing an existing dtb hint may break someone's booting device, if they use a close-to-mainline fork with that dtb name and/or panel compatibles below. You should avoid that whenever possible and align with whoever maintains the other device to make sure there is no breakage.
+CC @FrostI7Alex
There was a problem hiding this comment.
I agree that there should be only one msm8937-huawei-autumn, and at the moment there are no published device trees for them in the mainline msm89x7 fork. I didn't consider other models back then, so changing a dtb hint should be the case here.
Also, not exactly sure where you got "autumn" from, but I haven't dug deep enough for its codename, so maybe it is.
There was a problem hiding this comment.
aum is abbrevation for autumn https://phonedb.net/index.php?m=device&id=14016&c=huawei_honor_7a_pro_dual_sim_lte_emea_aum-l29__huawei_autumn
All huawei codname abbrevation have a full name
There was a problem hiding this comment.
Since the two board is different i would still prefer to split the dt msm8937-huawei-autumn-l29 and msm8937-huawei-autumn-l41 would be better.
5 participants
Add initial support for Huawei Honor 7A Pro (AUM-L29).
It is different from Huawei Honor 7C in panel names and in hardware (it doesn't have a second back camera).