-
Notifications
You must be signed in to change notification settings - Fork 425
dts: msm8952: Add support for Huawei Honor 7A Pro #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
artempeshkov
wants to merge
1
commit into
msm8916-mainline:main
Choose a base branch
from
artempeshkov:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| // SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| #include <skeleton64.dtsi> | ||
| #include <lk2nd.dtsi> | ||
|
|
||
| /* | ||
| * To flash lk2nd onto the device, you need to flash lk2nd as the | ||
| * kernel and flash an empty image in place of the ramdisk. | ||
| * To create an empty image use the following command: | ||
| * mkbootimg --kernel /dev/null --ramdisk /dev/null --base 0x80000000 --kernel_offset 0x00008000 --ramdisk_offset 0x02000000 --second_offset 0x00f00000 --tags_offset 0x00000100 --pagesize 2048 --header_version 0 -o ramdisk.img" | ||
| * | ||
| * As this device has no boot partition, you'll have to create | ||
| * one yourself. | ||
| * To create the partition follow these steps: | ||
| * ./parted /dev/block/mmcblk0 | ||
| * unit kB | ||
| * resizepart 55 31209799kB | ||
| * mkpart boot ext2 31209799kB 100% | ||
| * quit | ||
| * dd if=/dev/block/mmcblk0p41 of=/dev/block/mmcblk0p56 bs=1 seek=446 count=64 | ||
| */ | ||
|
|
||
| / { | ||
| qcom,msm-id = <QCOM_ID_MSM8937 0x00>; | ||
| qcom,board-id = <8319 0>; | ||
| }; | ||
|
|
||
| &lk2nd { | ||
| autumn-l29 { | ||
| model = "Huawei Honor 7A Pro (autumn-l29)"; | ||
| compatible = "huawei,autumn-l29"; | ||
| lk2nd,match-panel; | ||
|
|
||
| lk2nd,dtb-files = "msm8937-huawei-autumn-l29"; | ||
|
|
||
| gpio-keys { | ||
| compatible = "gpio-keys"; | ||
| up { | ||
| lk2nd,code = <KEY_VOLUMEUP>; | ||
| gpios = <&tlmm 91 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | ||
| }; | ||
| }; | ||
|
|
||
| panel { | ||
| compatible = "huawei,autumn-l29-panel", "lk2nd,panel"; | ||
|
|
||
| lcdkit_aum_l29_va_djn_cpt_ili9881c_5p7_hd_video { | ||
| compatible = "huawei,autumn-ili9881c"; | ||
| }; | ||
| lcdkit_aum_l29_va_djn_inx_ili9881c_5p7_hd_video { | ||
| compatible = "huawei,autumn-ili9881c"; | ||
| }; | ||
| lcdkit_aum_l29_va_ofilm_inx_ili9881c_5p7_hd_video { | ||
| compatible = "huawei,autumn-ili9881c"; | ||
| }; | ||
| lcdkit_aum_l29_va_tcl_csot_ft8613_5p7_hd_video { | ||
| compatible = "huawei,autumn-ft8613"; | ||
| }; | ||
| lcdkit_aum_l29_va_txd_hsd_hx8394f_5p7_hd_video { | ||
| compatible = "huawei,autumn-hx8394f"; | ||
| }; | ||
| lcdkit_aum_l29_va_txd_inx_hx8394f_5p7_hd_video { | ||
| compatible = "huawei,autumn-hx8394f"; | ||
| }; | ||
| }; | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide the link to where this device tree is, which explains why you have changed this line?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no such device tree in mainline yet, but, I changed it because there are two models with different hardware with the codename "autumn": AUM-L29 and AUM-L41, so they will need to have different mainline dtbs, and because aum is not the actual codename of these models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mainline device trees matters, so I am afraid that splitting them is not much point there to do so.
Single
msm8937-huawei-autumnshould be all we need at the moment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing an existing dtb hint may break someone's booting device, if they use a close-to-mainline fork with that dtb name and/or panel compatibles below. You should avoid that whenever possible and align with whoever maintains the other device to make sure there is no breakage.
+CC @FrostI7Alex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that there should be only one
msm8937-huawei-autumn, and at the moment there are no published device trees for them in the mainline msm89x7 fork. I didn't consider other models back then, so changing a dtb hint should be the case here.Also, not exactly sure where you got "autumn" from, but I haven't dug deep enough for its codename, so maybe it is.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aum is abbrevation for autumn https://phonedb.net/index.php?m=device&id=14016&c=huawei_honor_7a_pro_dual_sim_lte_emea_aum-l29__huawei_autumn
All huawei codname abbrevation have a full name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the two board is different i would still prefer to split the dt
msm8937-huawei-autumn-l29andmsm8937-huawei-autumn-l41would be better.