-
Notifications
You must be signed in to change notification settings - Fork 28
fluid system overhaul #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| -- or for rendering the pipes purely decorative. | ||
| ]] | ||
| pipeworks.toggles.pipe_mode = "classic" | ||
| pipeworks.toggles.pipe_mode = "pressure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does that affect existing worlds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a lot of the things I'm doing (whether they're currently in this PR or not) are going to break things, but the old way things work is likely simple enough to auto-reinstate the original function
|
Current luacheck warnings: (i removed the ones about missing sounds good imo, didn't test that yet though |
|
feature set in desc updated |
|
so....? |
|
any news here? |
|
? |
|
? |
| if core.get_modpath("bucket") then | ||
| buckets.air = "bucket:bucket_empty" | ||
| buckets.water = "bucket:bucket_water" | ||
| buckets.river_water = "bucket:bucket_river_water" | ||
| buckets.lava = "bucket:bucket_lava" | ||
| elseif core.get_modpath("mcl_buckets") then | ||
| buckets.air = "mcl_buckets:bucket_empty" | ||
| buckets.water = "mcl_buckets:bucket_water" | ||
| buckets.river_water = "mcl_buckets:bucket_river_water" | ||
| buckets.lava = "mcl_buckets:bucket_lava" | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should come from xcompat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be done
(riverwater & lava buckets don't have xcompat entries)
|
i have only skimmed this code, but would it be possible to break parts of this pr off and merge them in? as this is quite huge |
oddly enough, xcompat doesn't do anything with riverwater and lava
"Deprecate flowing_logic.lua for classic flow logic Mark the file as deprecated due to new flow logic requirements." - copilot
autocrafter fluid support
creative fluid source
trashcan acting as fluid void
flow sensor acting as a pressure gauge (shows fluid type too)
multiple fluid types (no mixing, but there is displacement)
| has custom fluid registration
| updating existing pump and drains to support multiple fluids
| per fluid "finite" config
(important detail: flow logic default set to
"pressure"instead of"classic")