Skip to content

Conversation

@rithik56
Copy link
Contributor

@rithik56 rithik56 commented Nov 8, 2025

Summary

This PR fixes an incorrect slot name in the mui-codemod transformer for Tabs props.

In tab-props.js, the codemod currently moves TabScrollButtonProps into a slot named scrollButton (singular).
However, according to the Tabs API, the correct slot is scrollButtons (plural).

@mui-bot
Copy link

mui-bot commented Nov 8, 2025

Netlify deploy preview

https://deploy-preview-47215--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 5260500

@rithik56
Copy link
Contributor Author

rithik56 commented Nov 8, 2025

@ZeeshanTamboli @sai6855 Please check this PR.

@rithik56
Copy link
Contributor Author

rithik56 commented Nov 8, 2025

@siriwatknp I am confused. Should it be scrollButton or scrollButtons. In MUI Docs, it is scrollButtons but ideally it should be scrollButton

@mj12albert
Copy link
Member

@siriwatknp I am confused. Should it be scrollButton or scrollButtons. In MUI Docs, it is scrollButtons but ideally it should be scrollButton

In the code it's plural: https://github.com/mui/material-ui/blob/master/packages/mui-material/src/Tabs/Tabs.js#L575C63-L575C76

@rithik56
Copy link
Contributor Author

@ZeeshanTamboli I tried pushing the empty commit but the CI is not getting triggered

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Nov 11, 2025

@siriwatknp There's a lot of inconsistency here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: codemod Specific to codemod.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants