Skip to content

Commit 8f702e1

Browse files
committed
Tweak njmax/nconmax
1 parent 1639b5c commit 8f702e1

File tree

4 files changed

+10
-19
lines changed

4 files changed

+10
-19
lines changed

src/mjlab/tasks/velocity/config/g1/env_cfgs.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,8 @@ def unitree_g1_rough_env_cfg(play: bool = False) -> ManagerBasedRlEnvCfg:
2626
"""Create Unitree G1 rough terrain velocity configuration."""
2727
cfg = make_velocity_env_cfg()
2828

29-
cfg.sim.mujoco.ccd_iterations = 500
30-
cfg.sim.contact_sensor_maxmatch = 500
31-
cfg.sim.nconmax = 70
29+
cfg.sim.njmax = 200
30+
cfg.sim.nconmax = 20
3231

3332
cfg.scene.entities = {"robot": get_g1_robot_cfg()}
3433

@@ -189,10 +188,7 @@ def unitree_g1_flat_env_cfg(play: bool = False) -> ManagerBasedRlEnvCfg:
189188
"""Create Unitree G1 flat terrain velocity configuration."""
190189
cfg = unitree_g1_rough_env_cfg(play=play)
191190

192-
cfg.sim.njmax = 300
193-
cfg.sim.mujoco.ccd_iterations = 50
194-
cfg.sim.contact_sensor_maxmatch = 64
195-
cfg.sim.nconmax = None
191+
cfg.sim.njmax = 170
196192

197193
# Switch to flat terrain.
198194
assert cfg.scene.terrain is not None

src/mjlab/tasks/velocity/config/go1/env_cfgs.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,11 @@ def unitree_go1_rough_env_cfg(
3535
"""Create Unitree Go1 rough terrain velocity configuration."""
3636
cfg = make_velocity_env_cfg()
3737

38-
cfg.sim.mujoco.ccd_iterations = 500
38+
cfg.sim.njmax = 100
39+
cfg.sim.nconmax = 20
40+
3941
cfg.sim.mujoco.impratio = 10
4042
cfg.sim.mujoco.cone = "elliptic"
41-
cfg.sim.contact_sensor_maxmatch = 500
4243

4344
cfg.scene.entities = {"robot": get_go1_robot_cfg()}
4445

@@ -269,10 +270,7 @@ def unitree_go1_flat_env_cfg(play: bool = False) -> ManagerBasedRlEnvCfg:
269270
"""Create Unitree Go1 flat terrain velocity configuration."""
270271
cfg = unitree_go1_rough_env_cfg(play=play)
271272

272-
cfg.sim.njmax = 300
273-
cfg.sim.mujoco.ccd_iterations = 50
274-
cfg.sim.contact_sensor_maxmatch = 64
275-
cfg.sim.nconmax = None
273+
cfg.sim.njmax = 50
276274

277275
# Switch to flat terrain.
278276
assert cfg.scene.terrain is not None

src/mjlab/tasks/velocity/mdp/curriculums.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ def terrain_levels_vel(
4747
# Robots that walked far enough progress to harder terrains.
4848
move_up = distance > terrain_generator.size[0] / 2
4949

50-
# Robots that walked less than half of their required distance go to
51-
# simpler terrains.
50+
# Robots that walked less than half of their required distance go to simpler terrains.
5251
move_down = (
5352
distance < torch.norm(command[env_ids, :2], dim=1) * env.max_episode_length_s * 0.5
5453
)
@@ -64,8 +63,8 @@ def terrain_levels_vel(
6463
"max": torch.max(levels),
6564
}
6665

67-
# In curriculum mode num_cols == num_terrains (one column per type),
68-
# so the column index directly maps to the sub-terrain name.
66+
# In curriculum mode num_cols == num_terrains (one column per type), so the column
67+
# index directly maps to the sub-terrain name.
6968
sub_terrain_names = list(terrain_generator.sub_terrains.keys())
7069
terrain_origins = terrain.terrain_origins
7170
assert terrain_origins is not None

src/mjlab/tasks/velocity/velocity_env_cfg.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -442,8 +442,6 @@ def make_velocity_env_cfg() -> ManagerBasedRlEnvCfg:
442442
azimuth=90.0,
443443
),
444444
sim=SimulationCfg(
445-
nconmax=35,
446-
njmax=1500,
447445
mujoco=MujocoCfg(
448446
timestep=0.005,
449447
iterations=10,

0 commit comments

Comments
 (0)