Use MullvadRustRuntime instead of mullvad-api in UI tests#9940
Use MullvadRustRuntime instead of mullvad-api in UI tests#9940pinkisemils wants to merge 9 commits intomainfrom
Conversation
5647aa1 to
e99d49d
Compare
|
🚨 End to end tests failed. Please check the failed workflow run. |
95c8887 to
20e4799
Compare
rablador
left a comment
There was a problem hiding this comment.
Code looks good, but we have very sad tests.
@rablador reviewed 12 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved.
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved.
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pinkisemils).
mullvad-ios/src/api_client/access_method_settings.rs line 164 at r3 (raw file):
number_of_elements: usize, ) -> Vec<AccessMethodSetting> { // `slice::from_raw_parts` will dereference the null pointer even if the slice is empty.
With this new change the safety message about raw_array is not correct anymore since it can be null now.
Serock3
left a comment
There was a problem hiding this comment.
@Serock3 reviewed 10 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pinkisemils).
450015a to
74ad0f3
Compare
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 7 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pinkisemils).
ios/MullvadVPN.xcodeproj/project.pbxproj line 7209 at r4 (raw file):
targetProxy = 0107F4122F5B02AD0012451B /* PBXContainerItemProxy */; }; 0107F4302F5F62950012451B /* PBXTargetDependency */ = {
Intentional...?
pinkisemils
left a comment
There was a problem hiding this comment.
@pinkisemils made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on rablador).
ios/MullvadVPN.xcodeproj/project.pbxproj line 7209 at r4 (raw file):
Previously, rablador (Jon Petersson) wrote…
Intentional...?
Yes.
rablador
left a comment
There was a problem hiding this comment.
@rablador resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved.
74ad0f3 to
efffbfb
Compare
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved.
Serock3
left a comment
There was a problem hiding this comment.
@Serock3 reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved.
mojganii
left a comment
There was a problem hiding this comment.
@mojganii made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on pinkisemils).
ios/MullvadVPNUITests/MullvadApi.swift line 2 at r5 (raw file):
// // MullvadApi.swift
This file resides in MullvadVPNUITests when I select “Show in Finder,” but in the project hierarchy it appears at the root level. Let’s move it so it also appears under MullvadVPNUITests in the project
ios/MullvadVPN.xcodeproj/project.pbxproj line 9041 at r5 (raw file):
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "DEBUG MULLVAD_ENVIRONMENT_STAGING"; SWIFT_EMIT_LOC_STRINGS = NO; SWIFT_OBJC_BRIDGING_HEADER = "$(PROJECT_DIR)/MullvadVPNUITests/BridgingHeader.h";
it seems the bridge file is still alive in MullvadVPNUITests folder while it's unnecessary
Whilst we did not actually act on our promise to do cleanup Thursday, here's some cleanup.
I do not know why we have these stray localizations - presumably they've been imported from the other platforms, and we're not using them?
This change is