Skip to content

Use MullvadRustRuntime instead of mullvad-api in UI tests#9940

Open
pinkisemils wants to merge 9 commits intomainfrom
deprecate-mullvadapiwrapper-in-partner-api-ios-1182
Open

Use MullvadRustRuntime instead of mullvad-api in UI tests#9940
pinkisemils wants to merge 9 commits intomainfrom
deprecate-mullvadapiwrapper-in-partner-api-ios-1182

Conversation

@pinkisemils
Copy link
Collaborator

@pinkisemils pinkisemils commented Mar 6, 2026

Whilst we did not actually act on our promise to do cleanup Thursday, here's some cleanup.

I do not know why we have these stray localizations - presumably they've been imported from the other platforms, and we're not using them?


This change is Reviewable

@pinkisemils pinkisemils added the iOS Issues related to iOS label Mar 6, 2026
@linear
Copy link

linear bot commented Mar 6, 2026

@pinkisemils pinkisemils force-pushed the deprecate-mullvadapiwrapper-in-partner-api-ios-1182 branch 2 times, most recently from 5647aa1 to e99d49d Compare March 6, 2026 13:25
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

🚨 End to end tests failed. Please check the failed workflow run.

@pinkisemils pinkisemils force-pushed the deprecate-mullvadapiwrapper-in-partner-api-ios-1182 branch from 95c8887 to 20e4799 Compare March 10, 2026 08:51
@pinkisemils pinkisemils requested a review from Serock3 March 10, 2026 08:52
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but we have very sad tests.

@rablador reviewed 12 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pinkisemils).


mullvad-ios/src/api_client/access_method_settings.rs line 164 at r3 (raw file):

    number_of_elements: usize,
) -> Vec<AccessMethodSetting> {
    // `slice::from_raw_parts` will dereference the null pointer even if the slice is empty.

With this new change the safety message about raw_array is not correct anymore since it can be null now.

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Serock3 reviewed 10 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pinkisemils).

@pinkisemils pinkisemils force-pushed the deprecate-mullvadapiwrapper-in-partner-api-ios-1182 branch from 450015a to 74ad0f3 Compare March 17, 2026 16:45
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 7 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pinkisemils).


ios/MullvadVPN.xcodeproj/project.pbxproj line 7209 at r4 (raw file):

			targetProxy = 0107F4122F5B02AD0012451B /* PBXContainerItemProxy */;
		};
		0107F4302F5F62950012451B /* PBXTargetDependency */ = {

Intentional...?

Copy link
Collaborator Author

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pinkisemils made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on rablador).


ios/MullvadVPN.xcodeproj/project.pbxproj line 7209 at r4 (raw file):

Previously, rablador (Jon Petersson) wrote…

Intentional...?

Yes.

rablador
rablador previously approved these changes Mar 19, 2026
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@rablador rablador force-pushed the deprecate-mullvadapiwrapper-in-partner-api-ios-1182 branch from 74ad0f3 to efffbfb Compare March 19, 2026 09:50
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Serock3 reviewed 5 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

Copy link
Contributor

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mojganii made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on pinkisemils).


ios/MullvadVPNUITests/MullvadApi.swift line 2 at r5 (raw file):

//
//  MullvadApi.swift

This file resides in MullvadVPNUITests when I select “Show in Finder,” but in the project hierarchy it appears at the root level. Let’s move it so it also appears under MullvadVPNUITests in the project


ios/MullvadVPN.xcodeproj/project.pbxproj line 9041 at r5 (raw file):

				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "DEBUG MULLVAD_ENVIRONMENT_STAGING";
				SWIFT_EMIT_LOC_STRINGS = NO;
				SWIFT_OBJC_BRIDGING_HEADER = "$(PROJECT_DIR)/MullvadVPNUITests/BridgingHeader.h";

it seems the bridge file is still alive in MullvadVPNUITests folder while it's unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iOS Issues related to iOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants