Add new getElementsSyncedByPlayer

[Xenius97]

Closes #2400

This PR adds new getElementsSyncedByPlayer which returns element table synced by player.

Shared:

table getElementsSyncedByPlayer()

[tederis]

LGTM

[qaisjp]

Thanks for the pull request!

isElementSyncer feedback

• I have concerns around the argument order of isElementSyncer server-side being confusing. Should the element be first, or the player be first? Currently in your pull request, the player is first.
• What's the benefit of isElementSyncer server-side when you can already do if element.syncer == player? This is more concise and doesn't introduce confusion around the argument order.

I'd prefer we remove the isElementSyncer portion of this pull request.

getElementsSyncedByPlayer feedback

The filter feels strange to me. Do we have other examples of filters being parsed as comma-separated strings?

The linked issue didn't really explain why they want to filter by type, so for now I'd suggest just returning all the elements. We can always add filtering in a future pull request.

[Xenius97]

Thanks for pointing this out!
I’ve removed the isElementSyncer part as suggested, and also removed the filter from getElementsSyncedByPlayer.

[qaisjp]

Thanks, this looks good. Btw it would be good if you merged the CStaticFunctionDefinitions directly into the luadefs.cpp file. (And removed the assertion.)

The CStaticFunctionDefinitions exists mainly for historical reasons and is not necessary for new functions

[Xenius97]

The CStaticFunctionDefinitions exists mainly for historical reasons and is not necessary for new functions

done