Skip to content

Conversation

stoneage-mta
Copy link
Contributor

When merged, this PR will:

  • Merge the PositionX, PositionY, PositionZ labels into one.

  • Move and re-scale "unread messages" and "screenshots" buttons from the "Player" tab.

  • Add new functionality: Hide Sensitive Data.

    • Useful for those who stream, share screens, or just want to share a simple screenshot. Works like "Streamer mode" in some apps, but in this case, it will never allow the admin panel to display the following data:
      • Players Tab:
        • Player serial
        • Player IP
        • Player account name
        • Player in-game localization
      • Server Tab:
        • Server password
  • Load and save the following data in client-side XML:

    • Anonymous Admin status
    • Hide Color Codes status
    • Hide Sensitive Data status

If it's approved, ill do the same for admin2.

Before:
image

After:
image

Co-authored-by: Gabrielius Laurinavičius <[email protected]>
Copy link
Contributor

@Dezash Dezash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aAdminReloadInfos() doesn't seem to reload Server Password
Also, some ideas for sensitive data:

  • Disable Bans and Admin Chat tabs
  • Ignore "Output admin messages to chat box" setting
  • Ignore "Output player information to console" setting or hide sensitive information in the console output

@Dutchman101
Copy link
Member

Good points @Dezash

I got another one, if you /report a player and select them from the list of players to report, admins will have suspect player information attached in the report under "View info"

So @iDannz-Breno you'd need to either disable opening reports while in "Hide sensitive data" mode, or mask player serial, IP address and account name in those reports

Copy link
Contributor Author

@stoneage-mta stoneage-mta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

about the last commit: I am not sure if this is the best way to do it, let me know if any of you have a better idea.

@stoneage-mta
Copy link
Contributor Author

Please let me know if you find anything else to change/add.

Copy link
Contributor

@Dezash Dezash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reported player info is broken, I've posted a suggestion to fix it
Also, aTab1.Name width should be increased because the stripped nickname part rarely fits:
image

@jlillis
Copy link
Contributor

jlillis commented May 11, 2021

@iDannz-Breno did you want this merged as is or did you want to make the same (or similar) changes to admin2 as mentioned? These changes look good and are approved.

@stoneage-mta
Copy link
Contributor Author

@jlillis, I think it is better to merge it as it is, maybe next week I can submit a new PR.

@stoneage-mta
Copy link
Contributor Author

Changes added to admin2 in #325.

Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve & merge as-is for admin but I have some additional comments for the admin2 implementation of this (#325).

@jlillis jlillis merged commit cfd4c3e into multitheftauto:master Jun 7, 2021
@stoneage-mta stoneage-mta deleted the idz-update-admin branch July 4, 2021 09:34
@patrikjuvonen patrikjuvonen added this to the 1.5.9 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants