-
-
Notifications
You must be signed in to change notification settings - Fork 171
admin: some improvements #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Gabrielius Laurinavičius <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aAdminReloadInfos() doesn't seem to reload Server Password
Also, some ideas for sensitive data:
- Disable Bans and Admin Chat tabs
- Ignore "Output admin messages to chat box" setting
- Ignore "Output player information to console" setting or hide sensitive information in the console output
Good points @Dezash I got another one, if you /report a player and select them from the list of players to report, admins will have suspect player information attached in the report under "View info" So @iDannz-Breno you'd need to either disable opening reports while in "Hide sensitive data" mode, or mask player serial, IP address and account name in those reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about the last commit: I am not sure if this is the best way to do it, let me know if any of you have a better idea.
Please let me know if you find anything else to change/add. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Gabrielius Laurinavičius <[email protected]>
Co-authored-by: Gabrielius Laurinavičius <[email protected]>
@iDannz-Breno did you want this merged as is or did you want to make the same (or similar) changes to admin2 as mentioned? These changes look good and are approved. |
@jlillis, I think it is better to merge it as it is, maybe next week I can submit a new PR. |
Changes added to admin2 in #325. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve & merge as-is for admin
but I have some additional comments for the admin2
implementation of this (#325).
When merged, this PR will:
Merge the PositionX, PositionY, PositionZ labels into one.
Move and re-scale "unread messages" and "screenshots" buttons from the "Player" tab.
Add new functionality: Hide Sensitive Data.
Load and save the following data in client-side XML:
If it's approved, ill do the same for admin2.
Before:

After:
