-
-
Notifications
You must be signed in to change notification settings - Fork 171
Update admin_servermaps.lua #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I made utils functions to return a boolean, this function is checking whether the feature is active or not, so it will return a false or a true one. Why did you do that? Well, when you go to the "Maps" tab, a variable will return an error, if the resource is not linked to the variable and leading to null within ipairs.
Well, thank you for the pull request, the idea is very good and I also have this same problem of ending up stopping the resource And another thing, within the original code, there is already a check if the resource exists, and if it does not exist it sends a trigger to the client with an empty table as result, and with a comment of "fake data". This behavior shouldn't be expected if the resource exists but is not being executed? (I didn't dive into the original code to find out if the result is really expected to be achieved - even if it is "fake") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are still a few other places (lines: 34, 43, 57 and 58) to replace getResourceFromName("mapmanager")
to the mapmanager
variable, but for some reason, i cant select them to comment on)
Co-authored-by: iDannz <[email protected]>
Co-authored-by: iDannz <[email protected]>
Co-authored-by: iDannz <[email protected]>
Co-authored-by: iDannz <[email protected]>
Now it looks good, maybe we should check if the same bug exists in admin2? |
I'll just wait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked and the admin2 resource doesn't use mapmanager
anywhere.
I made utils functions to return a boolean, this function is checking whether the feature is active or not, so it will return a false or a true one.
Why did you do that?
Well, when you go to the "Maps" tab, a variable will return an error, if the resource is not linked to the variable and leading to null within ipairs.