Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
burgholzer
left a comment
There was a problem hiding this comment.
LGTM besides two small details.
Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: Daniel Haag <121057143+denialhaag@users.noreply.github.com>
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThis PR updates CI runner matrices (adding macos-15/macos-15-intel and windows-2025, removing macos-14/windows-2022), swaps several lightweight jobs from Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
pyproject.toml (1)
10-15:⚠️ Potential issue | 🟡 MinorAdd comment documenting the nanobind constraint rationale.
The constraint
nanobind~=2.10.2is appropriate: nanobind 2.11.0 (released Jan 29, 2026) includes an ABI bump to version 18 and requires rebuilds of dependent extension modules. Since qcec depends onmqt.core(which also uses nanobind), mismatched ABI versions would break cross-module type sharing. However, add a comment explaining this incompatibility (e.g.,# ABI incompatible with nanobind 2.11.0+) so future maintainers understand the rationale before considering upgrades.Apply the same documentation to the
[dependency-groups] buildsection (lines 365–368)..pre-commit-config.yaml (1)
3-153:⚠️ Potential issue | 🟡 MinorConfirm that
priorityfield validation works in your CI environment.The
priorityfield is a prek-only feature and is not supported by upstreampre-commit(versions through 2025). Your.pre-commit-config.yamlusesprioritythroughout and is explicitly designed forprek(as shown in the comments and documented indocs/installation.md). However, your config also includes aci:section configured forpre-commit.ci, which uses standardpre-commitand does not recognize thepriorityfield.While your documentation correctly recommends
prekfor local development, you should verify that:
- Your CI workflows use
prek(not standardpre-commit)- OR
pre-commit.ciis properly configured to skip hooks or ignore unknown fields without failing validation
🤖 Fix all issues with AI agents
In @.github/workflows/cd.yml:
- Around line 40-42: The workflow uses runs-on: ubuntu-slim for the "🚀 Deploy
to PyPI" job which may lack build tooling; either switch the job's runs-on value
to ubuntu-latest or ensure you install required tools by adding a setup step
(e.g., actions/setup-python and explicit pip/build/toolchain installs) before
the build/publish steps—update the .github/workflows/cd.yml job named "🚀 Deploy
to PyPI" to use the safer runner or include those installation steps so PyPI
deployment succeeds.
Description
This PR updates the CI to use
macos-15instead ofmacos-14andwindows-2025instead ofwindows-2022. It furthermore updates.pre-commit-config.ymlto make use ofprek's priority feature.Checklist:
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.I have added migration instructions to the upgrade guide (if needed).