Set text property flags when begin hook is changed#32777
Open
miiizen wants to merge 1 commit intomusescore:4.7from
Open
Set text property flags when begin hook is changed#32777miiizen wants to merge 1 commit intomusescore:4.7from
miiizen wants to merge 1 commit intomusescore:4.7from
Conversation
Contributor
|
Tested and approved on Ubuntu 24.04.4 LTS. |
mike-spa
reviewed
Mar 27, 2026
| setPropertyFlags(Pid::END_TEXT, endTextStyleFlag); | ||
| triggerLayout(); | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
Looks ok but could you explain why Pedal is different from all other TextLineBase elements in this regard?
Contributor
Author
There was a problem hiding this comment.
See Pedal::getPropertyStyle. The style value (and so the default) associated with begin & continue text depends on the begin hook type and the end text default depends on the line being visible. When the property they depend on changes, we need to set the style flags based on the new default.
The default value of text depends on the value of begin hook
miiizen
force-pushed
the
32750-pedalTextFlag
branch
from
32231b7 to
1bf1bec
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #32750
This fixes the issue for new palette items and scores. Unfortunately, I can't see a way to deal with opening existing scores/palette items as these is missing information.