Refactor: move mandatory migrations into EngravingCompat#32847
Draft
cbjeukendrup wants to merge 5 commits intomusescore:masterfrom
Draft
Refactor: move mandatory migrations into EngravingCompat#32847cbjeukendrup wants to merge 5 commits intomusescore:masterfrom
cbjeukendrup wants to merge 5 commits intomusescore:masterfrom
Conversation
cbjeukendrup
force-pushed
the
mandatory-migrations-to-engraving-compat
branch
from
cd8f780 to
bb8ab16
Compare
It is already called in `MscLoader::loadMscz`, so no need to call it in individual reader implementations.
`Score`’s implementation of these methods just its calls `MasterScore`’s version. Also, `scoreList` includes the master score itself, so no need to call `createPaddingTable` separately.
It serves no purpose and meta tags are not the place for `mscVersion`.
cbjeukendrup
force-pushed
the
mandatory-migrations-to-engraving-compat
branch
from
bb8ab16 to
d6c966f
Compare
Collaborator
Author
|
The VTests changes are expected, because now they represent how the score will look when opening it in the UI (regardless of selected migration options). |
cbjeukendrup
commented
Mar 29, 2026
| if (mscVersion < 300) { | ||
| resetAllElementsPositions(score); | ||
| resetCrossBeams(score); | ||
| needRelayout = true; |
Collaborator
Author
There was a problem hiding this comment.
Question to the team: do we think it's necessary to do this after initial layout, requiring a second layout? Or is it not necessary to do a layout before it?
fullCross only seems to be updated at layout time, that's why I was thinking it would be necessary. But it is not entirely clear to me whether a layout has already been done by the time that IProjectMigrator does its job, where these resets were performed previously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.