Unmarshalling take precedence over decoding #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djthorpe
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the order of response decoding logic to prioritize custom Unmarshaler implementations over MIME type-based standard decoders (JSON, XML, etc.). Previously, custom unmarshalers were only used as a fallback for unknown MIME types.
Changes:
- Moved the
Unmarshalerinterface check to execute before the MIME type switch statement - Added clarifying comment about preferring custom Unmarshaler when implemented
- Removed redundant Unmarshaler check from the default case
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the order of response decoding logic to prioritize custom Unmarshaler implementations over MIME type-based standard decoders (JSON, XML, etc.). Previously, custom unmarshalers were only used as a fallback for unknown MIME types.
Changes: