Skip to content

Unmarshalling take precedence over decoding #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djthorpe merged 1 commit into from
Jan 11, 2026
Merged

Unmarshalling take precedence over decoding #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,11 @@ func do(client *http.Client, req *http.Request, accept string, strict bool, trac
return nil
}

// Decode the body
// Decode the body, preferring custom Unmarshaler when implemented
if v, ok := out.(Unmarshaler); ok {
return v.Unmarshal(response.Header, response.Body)
}

switch mimetype {
case ContentTypeJson, ContentTypeJsonStream:
// JSON decode is streamable
Expand All @@ -343,9 +347,7 @@ func do(client *http.Client, req *http.Request, accept string, strict bool, trac
return err
}
default:
if v, ok := out.(Unmarshaler); ok {
return v.Unmarshal(response.Header, response.Body)
} else if v, ok := out.(io.Writer); ok {
if v, ok := out.(io.Writer); ok {
if _, err := io.Copy(v, response.Body); err != nil {
return err
}
Expand Down
Loading