Skip to content

tool: make doc-gen and react-build to work on Windows#1251

Merged
luwes merged 2 commits intomuxinc:mainfrom
aarnchng:build_win
Dec 18, 2025
Merged

tool: make doc-gen and react-build to work on Windows#1251
luwes merged 2 commits intomuxinc:mainfrom
aarnchng:build_win

Conversation

@aarnchng
Copy link
Contributor

@aarnchng aarnchng commented Dec 15, 2025

Make doc generation work on Windows.
resolves #1184 and #1250.

@aarnchng aarnchng requested review from a team and heff as code owners December 15, 2025 07:34
@vercel
Copy link

vercel bot commented Dec 15, 2025

@aarnchng is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io
Copy link

snyk-io bot commented Dec 15, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@aarnchng aarnchng changed the title tool: make doc-gen and react-build to work on Windows #1250 tool: make doc-gen and react-build to work on Windows Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.66%. Comparing base (3ea80df) to head (d20fd56).
⚠️ Report is 275 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
- Coverage   78.55%   73.66%   -4.90%     
==========================================
  Files          59       56       -3     
  Lines       11080    13670    +2590     
  Branches        0      782     +782     
==========================================
+ Hits         8704    10070    +1366     
- Misses       2376     3567    +1191     
- Partials        0       33      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel
Copy link

vercel bot commented Dec 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
media-chrome Ready Ready Preview, Comment Dec 18, 2025 6:46pm
media-chrome-demo-nextjs Ready Ready Preview, Comment Dec 18, 2025 6:46pm
media-chrome-docs Ready Ready Preview, Comment Dec 18, 2025 6:46pm

Copy link
Collaborator

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@luwes luwes merged commit 4b1f5a9 into muxinc:main Dec 18, 2025
17 of 19 checks passed
@ronalduQualabs
Copy link
Contributor

@aarnchng Thank you very much for taking the time to look into the code and collaborate. We greatly appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm run build:react on Windows fails to build

3 participants