refactor: optimize cache code architeture#2921
refactor: optimize cache code architeture#2921causeThenEffect wants to merge 1 commit intomybatis:masterfrom
Conversation
|
seems mostly good but what about the hash, equals, etc you removed but did not add to the main object to process with the delegate. That may in fact be important especially to the cache. Not sure if the downstream cache projects are in fact calling those. They could be so I think you need to add them just to be safe since this is a fairly big change. |
|
Thank you for the PR, @causeThenEffect ! I haven't looked into it, but there are test failures. |
|
This appears to be a duplicate of #838. If necessary, I can reopen it. After rebase, it's here wuwen5@a795b01 |
|
@wuwen5 Go ahead and reopen. If it is just a rehash, no one said anything the first time through, we should be able to compare them. Main thing is it has to build successfully and address any concerns. |
I think refactored code can reduce code redundancy