Skip to content

Conversation

jeffgbutler
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 02fce4b on jeffgbutler:flakey-tests
into 1901835 on mybatis:master.

@jeffgbutler jeffgbutler merged commit a828741 into mybatis:master Oct 7, 2025
7 checks passed
@jeffgbutler jeffgbutler deleted the flakey-tests branch October 7, 2025 18:12
@bee0511
Copy link
Contributor

bee0511 commented Oct 8, 2025

Hi @jeffgbutler 👋

I noticed that after the earlier PRs like #981 and #982 fixing similar flaky tests were merged, you also fixed several other tests with the same issue in this PR (containsExactly changed to containsOnly).
I was curious how you found those tests. Did you use NonDex, or just search the codebase manually with something like grep containsExactly?

If there are other repositories you’d like me to check for similar problems, I’d be happy to help.

Thanks!

@jeffgbutler
Copy link
Member Author

I searched with IntelliJ's "find in files". We've never seen an actual instance of the tests being flakey as far as I know, but better safe than sorry.

@bee0511
Copy link
Contributor

bee0511 commented Oct 8, 2025

I searched with IntelliJ's "find in files". We've never seen an actual instance of the tests being flakey as far as I know, but better safe than sorry.

Thanks for the quick reply! That makes sense. Using IntelliJ’s search is definitely an easy way to catch similar cases. Glad to hear those tests didn’t actually fail in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants