-
Notifications
You must be signed in to change notification settings - Fork 324
Add the multi language support, and add the german version in the docs #1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @mylinuxforwork I wanted to add the french version too, but i was afraid to create a PR with 80 new files ^^. So tell me, if you want to merge the PR, do you want me to add a commit for the french version or i wait to create a new PR when this one will be merged ? :) |
|
@Esscraye Thank you so much for your work. But I would currently pause your request. It would be hard for me to maintain two language versions in the docs. But maybe you can support me in the general english version? |
|
@Esscraye thanks for your work, LGTM. can you provide me the site URL deployed with the GitHub actions workflow? I want to check if everything works. edit: also can you like update the docs in de in upcoming times, like if the normal eng version changes, can you also update the de version yourself. i can agree with ml4w that maintaining two languages is a bit difficult when there are too many things in the docs, so if you can help ml4w while maintaining the docs in de, it will be good to have them in de lang. if you can lend your helping hand in future updates of the docs, we can look further to have de lang in the docs. |
|
hey, I don't think i've the time to maintain the german version, i'm sorry about that ^^ @harilvfs it should be that : https://esscraye.github.io/ml4w-dotfiles/ but it seems the github-page is not really working well ? |
…an (de) translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds comprehensive multi-language support to the VitePress documentation site and provides a complete German (de) translation. The changes enable German-speaking users to access the ML4W Dotfiles documentation in their native language while maintaining the existing English documentation.
Key changes:
- Implemented VitePress i18n infrastructure with locale-aware navigation and sidebar helpers
- Added complete German translation covering all documentation sections
- Fixed minor issues in English documentation (typo corrections and updated links)
Reviewed changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/usage/screenshots.md | Fixed typo: "spappy" → "swappy" |
| docs/usage/keybindings.md | Updated GitHub link path from share/dotfiles to dotfiles |
| docs/help/troubleshooting.md | Changed code fence language from sh to ini for SDDM config |
| docs/development/wiki.md | Added multi-language setup instructions and removed outdated information |
| docs/.vitepress/config.ts | Implemented locale system with nav() and sidebar() helper functions supporting i18n |
| docs/de/**/*.md | Complete German translation of all documentation pages |
| docs/de/showcases/*.{ts,vue} | German version of showcase components |
| docs/customization/displaymanager.md | Changed code fence language from sh to ini for configuration examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| </div> | ||
|
|
||
| As an example, let's install brave. |
Copilot
AI
Dec 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line contains English text in a German translation file. It should be translated to German. The English text "As an example, let's install brave." appears in what should be a fully German document.
| As an example, let's install brave. | |
| Als Beispiel installieren wir Brave. |
| type Showcase = { | ||
| image: string | ||
| title: string | ||
| } |
Copilot
AI
Dec 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TypeScript type definition is incomplete. The type declares 'image' and 'title' as required properties, but objects in the array use 'videoUrl' which is not defined in the type. The type should include 'videoUrl' as an optional property, or the properties should be marked as optional.
| > | ||
| > Documentation in languages other than English may not be up to date. Check the date and the ml4w version shown, and consult the English documentation if in doubt. | ||
| ** To add a new language, follow these steps:** |
Copilot
AI
Dec 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra space before "To add a new language". The markdown has "** To add" with two asterisks and a space, which should be "**To add" without the space for proper bold formatting.
|
|
||
| const sidebar = (lang = "", override = {}) => { | ||
| // future feature may be needed: sep sidebar for dots-installer section or any other | ||
| // basicallyy when user visits /dots-installer/ page it will only show dots-installer menu items |
Copilot
AI
Dec 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in the comment: "basicallyy" should be "basically".
| // basicallyy when user visits /dots-installer/ page it will only show dots-installer menu items | |
| // basically when user visits /dots-installer/ page it will only show dots-installer menu items |
| const sidebar = (lang = "", override = {}) => { | ||
| // future feature may be needed: sep sidebar for dots-installer section or any other | ||
| // basicallyy when user visits /dots-installer/ page it will only show dots-installer menu items | ||
| // just like how vitepress docs sep "refrence" section https://vitepress.dev/ |
Copilot
AI
Dec 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in the comment: "refrence" should be "reference".
| // just like how vitepress docs sep "refrence" section https://vitepress.dev/ | |
| // just like how vitepress docs sep "reference" section https://vitepress.dev/ |
Description
This pull request adds VitePress multi-language support and includes a complete German (de) translation of the documentation under de.
Changes
Context
This change enables multi-language documentation for the site and provides a full German translation, allowing German-speaking users to read the docs in their native language. It adds locale-aware configuration in config.ts (helpers for
navandsidebar) and places all translated content underdocs/de. No functional changes to the application or runtime are included — only documentation and site config updates.How Has This Been Tested?
Checklist
Please ensure your pull request meets the following requirements:
config.tsare commented).Screenshots
Related Issues
N/A
Additional Notes