Improve Node.elements and Transforms.mergeNodes tests#1
Merged
nabbydude merged 2 commits intonabbydude:fix-testsfrom Jan 20, 2026
Merged
Improve Node.elements and Transforms.mergeNodes tests#1nabbydude merged 2 commits intonabbydude:fix-testsfrom
Node.elements and Transforms.mergeNodes tests#1nabbydude merged 2 commits intonabbydude:fix-testsfrom
Conversation
12joan
changed the title
Node.elements and Transforms.mergeNodes tests
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child PR of ianstormtaylor#6003
I've improved the poor-quality tests you identified, along with others in the same directories as them.
Nodeelementsall,reverse- Modified the input data to actually include multiple elements to return, including nested elementsrange,path- Removed these in favour offromandtomergeNodespathblock-nested- As you pointed out, this passes even without thematch. I don't think thematchis important to the intent of the test ("Can we merge two adjacent block-containing blocks?"), so I've removed ittext-hanging,text-hanging-nested- Again, thematchwas unnecessary, so I've removed it. Also, the tests were such that simply normalizing the editor is enough to cause them to pass, so I've disabled normalizing in these tests to force theTransforms.mergeNodesto transform the data itself.