Skip to content

Improve Node.elements and Transforms.mergeNodes tests #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nabbydude merged 2 commits into from
Jan 20, 2026
Merged

Improve Node.elements and Transforms.mergeNodes tests #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
166e1f5
Improve `Node.elements` tests
12joan Jan 19, 2026
eaa933b
Improve `Transforms.mergeNodes` tests
12joan Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions packages/slate/test/interfaces/Node/elements/all.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,32 @@
/** @jsx jsx */
import { Node } from 'slate'
import { Editor, Node } from 'slate'
import { jsx } from 'slate-hyperscript'

export const input = (
<editor>
<element>
<text key="a" />
<text key="b" />
</element>
<element>
<element>
<text key="b1" />
</element>
<element>
<text key="b2" />
</element>
</element>
<element>
<text key="c" />
</element>
</editor>
)
export const test = value => {
return Array.from(Node.elements(value))
}
export const output = [
[
<element>
<text key="a" />
<text key="b" />
</element>,
[0],
],
Editor.node(input, [0]),
Editor.node(input, [1]),
Editor.node(input, [1, 0]),
Editor.node(input, [1, 1]),
Editor.node(input, [2]),
]
30 changes: 30 additions & 0 deletions packages/slate/test/interfaces/Node/elements/from.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/** @jsx jsx */
import { Editor, Node } from 'slate'
import { jsx } from 'slate-hyperscript'

export const input = (
<editor>
<element>
<text key="a" />
</element>
<element>
<element>
<text key="b1" />
</element>
<element>
<text key="b2" />
</element>
</element>
<element>
<text key="c" />
</element>
</editor>
)
export const test = value => {
return Array.from(Node.elements(value, { from: [1, 1] }))
}
export const output = [
Editor.node(input, [1]),
Editor.node(input, [1, 1]),
Editor.node(input, [2]),
]
29 changes: 0 additions & 29 deletions packages/slate/test/interfaces/Node/elements/path.tsx
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions packages/slate/test/interfaces/Node/elements/range.tsx
View file
Open in desktop

This file was deleted.

26 changes: 17 additions & 9 deletions packages/slate/test/interfaces/Node/elements/reverse.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,32 @@
/** @jsx jsx */
import { Node } from 'slate'
import { Editor, Node } from 'slate'
import { jsx } from 'slate-hyperscript'

export const input = (
<editor>
<element>
<text key="a" />
<text key="b" />
</element>
<element>
<element>
<text key="b1" />
</element>
<element>
<text key="b2" />
</element>
</element>
<element>
<text key="c" />
</element>
</editor>
)
export const test = value => {
return Array.from(Node.elements(value, { reverse: true }))
}
export const output = [
[
<element>
<text key="a" />
<text key="b" />
</element>,
[0],
],
Editor.node(input, [2]),
Editor.node(input, [1]),
Editor.node(input, [1, 1]),
Editor.node(input, [1, 0]),
Editor.node(input, [0]),
]
30 changes: 30 additions & 0 deletions packages/slate/test/interfaces/Node/elements/to.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/** @jsx jsx */
import { Editor, Node } from 'slate'
import { jsx } from 'slate-hyperscript'

export const input = (
<editor>
<element>
<text key="a" />
</element>
<element>
<element>
<text key="b1" />
</element>
<element>
<text key="b2" />
</element>
</element>
<element>
<text key="c" />
</element>
</editor>
)
export const test = value => {
return Array.from(Node.elements(value, { to: [1, 0] }))
}
export const output = [
Editor.node(input, [0]),
Editor.node(input, [1]),
Editor.node(input, [1, 0]),
]
1 change: 0 additions & 1 deletion packages/slate/test/transforms/mergeNodes/path/block-nested.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export const input = (
export const run = editor => {
Transforms.mergeNodes(editor, {
at: [1],
match: (n, p) => p.length === 1,
})
}
export const output = (
Expand Down
13 changes: 9 additions & 4 deletions packages/slate/test/transforms/mergeNodes/path/text-hanging-nested.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** @jsx jsx */
import { Transforms, Text } from 'slate'
import { Transforms } from 'slate'
import { jsx } from '../../..'

export const input = (
Expand All @@ -8,20 +8,25 @@ export const input = (
<block>
<block>
<cursor />
<text />
<text>two</text>
</block>
</block>
</editor>
)
export const run = editor => {
Transforms.mergeNodes(editor, { at: [1, 0, 1], match: Text.isText })
// Disable normalizing, since otherwise this test passes due to it
editor.normalizeNode = () => {}
Transforms.mergeNodes(editor, { at: [1, 0, 1] })
}
export const output = (
<editor>
<block>one</block>
<block>
<block>
<cursor />
<text>
<cursor />
two
</text>
</block>
</block>
</editor>
Expand Down
6 changes: 4 additions & 2 deletions packages/slate/test/transforms/mergeNodes/path/text-hanging.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** @jsx jsx */
import { Transforms, Text } from 'slate'
import { Transforms } from 'slate'
import { jsx } from '../../..'

export const input = (
Expand All @@ -12,7 +12,9 @@ export const input = (
</editor>
)
export const run = editor => {
Transforms.mergeNodes(editor, { at: [1, 1], match: Text.isText })
// Disable normalizing, since otherwise this test passes due to it
editor.normalizeNode = () => {}
Transforms.mergeNodes(editor, { at: [1, 1] })
}
export const output = (
<editor>
Expand Down