making default functions to closures#899
Open
thinkrapido wants to merge 1 commit intonannou-org:masterfrom
Open
making default functions to closures#899thinkrapido wants to merge 1 commit intonannou-org:masterfrom
thinkrapido wants to merge 1 commit intonannou-org:masterfrom
Conversation
bf3f0ac to
3d7f49e
Compare
3d7f49e to
bc457e0
Compare
Author
|
all the examples need to be improved due to this pull request |
Contributor
|
Using closures instead of
trait FooFn {
fn foo(&mut self);
}
impl<F: FnMut()> FooFn for F {
fn foo(&mut self) {
self()
}
}
fn consumes_foo(foo_fn: impl FooFn) {
let boxed: Box<dyn FooFn> = Box::new(foo_fn);
}
fn calls_foo() {
consumes_foo(|| {})
} |
|
@thinkrapido Did you make any progresses with this PR? I just ran into the issue of passing state from outside |
Author
|
@abey79 , no I didn't. For me the pull request solved to problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to suggest a pull request to make the default functions like ModelFn, UpdateFn, etc... usable as a closure.
Related: #793
It is a very easy fix and we gain much more flexibility in developing complex programs.
A call would be via an macro
and to respective functions.
Also read, how it is meant: https://medium.com/@romeo-disca/smart-pointers-in-rust-158046006f15