bug fix: chain comparison not plotting properly#106
Open
jeremy-baier wants to merge 2 commits intonanograv:mainfrom
Open
bug fix: chain comparison not plotting properly#106jeremy-baier wants to merge 2 commits intonanograv:mainfrom
jeremy-baier wants to merge 2 commits intonanograv:mainfrom
Conversation
Collaborator
Author
|
i think this should be the fix. but i have not had time to test it yet. will try to do that tomorrow. |
Collaborator
|
This will need to be partially reworked @jeremy-baier with the changes introduced in by #127. ~ Joe G. |
rossjjennings
approved these changes
Dec 9, 2025
Member
|
@jeremy-baier Is there any reason we shouldn't just merge this? It's been languishing for a while, but the change is very simple, and despite Joe's comment above, I don't think there's any conflict with #127. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the new noise chains were being compared to themselves rather than being compared to the old version of the chains which were passed.